feat: add version of plugin in the error title #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matteo-cristino
commented
May 22, 2024
matteo-cristino
commented
- feat(core): add @slangroom/core version on parse error
- refactor(core): improve @slangroom&core package version print on error
- feat: add version on error to almost all plugins
This should be extended to all type of errors
|
waiting for #134 to extend this error also to |
now json import is working but with a warning: (node:17829) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time (Use to show where the warning was created)
|
The error seems pretty persistent in the CI now, but I am not able to reproduce it locally 🤷 |
|
@matteo-cristino Then I guess should be something with the way we run the pocketbase service within the github actions... maybe double check the forkbombeu/signroom repo actions |
puria
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.